Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Improve Errors AWS Errors #1100

Merged
merged 5 commits into from
Jun 27, 2022

Conversation

bbernays
Copy link
Contributor

@bbernays bbernays commented Jun 23, 2022

Summary

  • Improve Error message when CQ is unable to assume a role in a org member account
  • Enable Account and Org to be in same config

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays requested a review from a team as a code owner June 23, 2022 21:12
@bbernays bbernays requested review from irmatov and removed request for a team June 23, 2022 21:12
@bbernays bbernays requested a review from yevgenypats June 24, 2022 12:08
Copy link
Member

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think we need to introduce tests for that both to validate this is correct and also to help with future regression and maybe add docs supporting that

@bbernays
Copy link
Contributor Author

Looks good but I think we need to introduce tests for that both to validate this is correct and also to help with future regression and maybe add docs supporting that

Great catch. There would have been regressions had this merged with how the STS client is passed around to assume roles. I have updated the PR to explicitly return an error if a user tries to create this specification until we can do a larger refactor.

@bbernays bbernays requested a review from yevgenypats June 27, 2022 14:31
@bbernays bbernays changed the title fix: Improve Errors and Support Both Account and Org fix: Improve Errors AWS Errors Jun 27, 2022
@bbernays bbernays merged commit 1897dbc into cloudquery:main Jun 27, 2022
@bbernays bbernays deleted the improve-aws-orgs-errors branch June 27, 2022 18:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants