Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Account specific default_region #1177

Merged
merged 6 commits into from
Jul 7, 2022

Conversation

bbernays
Copy link
Contributor

@bbernays bbernays commented Jul 6, 2022

Summary:

Closes #1176


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here πŸ§ͺ
  • Update the docs by running go run ./docs/docs.go and committing the changes πŸ“ƒ
  • If adding a new resource, add relevant Terraform files in a separate PR πŸ“‚
  • Ensure the status checks below are successful βœ…

@bbernays bbernays requested a review from a team as a code owner July 6, 2022 18:28
@bbernays bbernays requested review from hermanschaaf and removed request for a team July 6, 2022 18:28
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1180 I think this issue is relevant as well for ListBuckets as we have a us-east-1 hard coded in there so I would assume to access the default region should be used there as well instead of the hard coded value.

Copy link
Member

@hermanschaaf hermanschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions from me, but LGTM πŸ‘

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
client/client.go Outdated Show resolved Hide resolved
bbernays and others added 2 commits July 7, 2022 07:07
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
Co-authored-by: Herman Schaaf <hermanschaaf@gmail.com>
@bbernays bbernays merged commit ac0e91b into cloudquery:main Jul 7, 2022
@bbernays bbernays deleted the account-specific-region branch July 7, 2022 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assume Role in non AWS Partition
3 participants