Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Support Xray groups and sampling rules #841

Merged
merged 10 commits into from
May 11, 2022
Merged

feat: Support Xray groups and sampling rules #841

merged 10 commits into from
May 11, 2022

Conversation

zagronitay
Copy link
Contributor

@zagronitay zagronitay commented May 4, 2022 •
edited
Loading

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

closes #715

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@github-actions github-actions bot added the feat label May 4, 2022
@zagronitay zagronitay marked this pull request as ready for review May 9, 2022 09:26
@zagronitay zagronitay requested a review from a team as a code owner May 9, 2022 09:26
@zagronitay zagronitay requested review from roneli and removed request for a team May 9, 2022 09:26
disq
disq approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@disq disq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

roneli
roneli approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zagronitay zagronitay merged commit e9c57b8 into cloudquery:main May 11, 2022
This was referenced May 11, 2022
Closed
Merged
@zagronitay zagronitay deleted the feat/xray-sampling-rules-group branch May 25, 2022 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roneli roneli roneli approved these changes

@disq disq disq approved these changes

Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for AWS::XRay::*
3 participants
@zagronitay @disq @roneli