Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Ignore NotFound on all aws resoruces #982

Merged

Conversation

roneli
Copy link
Contributor

@roneli roneli commented Jun 1, 2022

πŸŽ‰ Thank you for making CloudQuery awesome by submitting a PR πŸŽ‰

Summary

Closes #973

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines πŸ§‘β€πŸŽ“
  • Run go fmt to format your code πŸ–Š
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here πŸ§ͺ
  • Update the docs by running go run ./docs/docs.go and committing the changes πŸ“ƒ
  • If adding a new resource, add relevant Terraform files in a separate PR πŸ“‚
  • Ensure the status checks below are successful βœ…

@roneli roneli requested a review from a team as a code owner June 1, 2022 08:56
@roneli roneli requested review from disq, bbernays and yevgenypats and removed request for a team and disq June 1, 2022 08:56
@roneli roneli self-assigned this Jun 1, 2022
@roneli roneli added the bug Something isn't working label Jun 1, 2022
@roneli roneli merged commit a68e885 into cloudquery:main Jun 1, 2022
@roneli roneli deleted the fix/ignore_not_found_on_all_resources branch June 1, 2022 12:43
kodiakhq bot pushed a commit that referenced this pull request Jun 2, 2022
πŸ€– I have created a release *beep* *boop*
---


### [0.12.4](v0.12.3...v0.12.4) (2022-06-01)


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-gen to v0.0.5 ([#984](#984)) ([9c7fd19](9c7fd19))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.7 ([#985](#985)) ([6fe6cc0](6fe6cc0))
* Fixed Auth config diagnostics level ([#987](#987)) ([9e8be90](9e8be90))
* Ignore NotFound on all aws resoruces ([#982](#982)) ([a68e885](a68e885))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Default Error Handling Behavior
4 participants