Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

feat: Added Target Health Descriptions to Target Groups #996

Merged
merged 2 commits into from
Jun 6, 2022
Merged

feat: Added Target Health Descriptions to Target Groups #996

merged 2 commits into from
Jun 6, 2022

Conversation

mlozoya2
Copy link
Contributor

@mlozoya2 mlozoya2 commented Jun 2, 2022 •
edited
Loading

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Closes #926

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@mlozoya2 mlozoya2 requested a review from a team as a code owner June 2, 2022 21:10
@mlozoya2 mlozoya2 requested review from irmatov and removed request for a team June 2, 2022 21:10
@bbernays bbernays requested a review from roneli June 2, 2022 21:10
roneli
roneli reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for your contribution, migrations aren't required anymore, so they can be removed

@roneli roneli merged commit d1ffc37 into cloudquery:main Jun 6, 2022
@cq-bot cq-bot mentioned this pull request Jun 6, 2022
Merged
@mlozoya2 mlozoya2 deleted the elbv2-target-group-target-health branch June 6, 2022 20:25
kodiakhq bot pushed a commit that referenced this pull request Jun 7, 2022
@cq-bot
chore(main): Release v0.12.6 (#1007)
f485a5d 
🤖 I have created a release *beep* *boop*
---


## [0.12.6](v0.12.5...v0.12.6) (2022-06-07)


### Features

* Added Target Health Descriptions to Target Groups ([#996](#996)) ([d1ffc37](d1ffc37))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.8 ([#1011](#1011)) ([0d8f687](0d8f687))
* Update endpoints ([#1008](#1008)) ([6bfa91a](6bfa91a))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbernays bbernays bbernays left review comments

@roneli roneli roneli approved these changes

@irmatov irmatov Awaiting requested review from irmatov irmatov is a code owner automatically assigned from cloudquery/cloudquery-opensource

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ELB Target Group Health
3 participants
@mlozoya2 @bbernays @roneli