Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to using new docPath for Firestore including projectID #215

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Migrate to using new docPath for Firestore including projectID #215

merged 1 commit into from
Mar 5, 2024

Conversation

nielm
Copy link
Collaborator

@nielm nielm commented Feb 23, 2024

Fixes #213

Migrations location of state doc in Firestore storage from

autoscaler/${instanceId}

to

spannerAutoscaler/state/projects/${projectId}/instances/${instanceId}

Avoids clashes when instances have the same names in different projects

@nielm nielm force-pushed the firestoreDoc branch 2 times, most recently from dad05d0 to 3801bf4 Compare February 23, 2024 14:46
@henrybell henrybell self-assigned this Feb 23, 2024
@henrybell henrybell added bug Something isn't working testing labels Feb 23, 2024
@nielm nielm force-pushed the firestoreDoc branch 4 times, most recently from a202b88 to 1910a88 Compare February 27, 2024 14:38
henrybell
henrybell reviewed Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@henrybell henrybell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, other than that, LGTM!

src/scaler/scaler-core/state.js Show resolved Hide resolved
@henrybell henrybell merged commit aa19f02 into cloudspannerecosystem:master Mar 5, 2024
8 checks passed
@nielm nielm deleted the firestoreDoc branch March 11, 2024 18:00
nielm added a commit that referenced this pull request Mar 11, 2024
@nielm
fix: Migrate to using new docPath for Firestore including projectID (#…
1561736 
…215)

DocPath in firestore did not include project ID running the risk
of potential state overwrites if the same instance ID was using in
multiple projects

Originally merged in #215
@release-please release-please bot mentioned this pull request Mar 11, 2024
Closed
nielm added a commit that referenced this pull request Mar 12, 2024
@nielm
fix: Migrate to using new docPath for Firestore including projectID (#…
3d9771d 
…215)

fixes #213
This was referenced Mar 12, 2024
Merged
Closed
This was referenced Mar 26, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrybell henrybell henrybell approved these changes

Assignees

@henrybell henrybell

Labels
bug Something isn't working testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No support for multiple projects in Firestore storage
2 participants
@nielm @henrybell