fix: Prevent metrics from being sent too frequently to OTEL collector #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cloudspannerecosystem#250 When using the GKE decoupled deployment, it is possible that a race condition can occur where the Scaler with a 10s periodic export may report metrics more frequently than the OTEL collector's batching interval (also 10s), leading to multiple sets of metrics being pushed to the downstream metrics manager. This can cause Duplicate TimeSeries errors. Update the counters to push metrics less frequently in periodic export mode, and ensure that metrics are never flushed manually in this mode. In addition the OTEL collector in unified mode had a 5s default time for batching which is at the limit of the Google Cloud Monitoring requirements that pushes are at least 5s apart.
henrybell
requested changes
Mar 20, 2024
henrybell
approved these changes
Mar 20, 2024
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #250
When using the GKE decoupled deployment, it is possible that a race condition can occur where the Scaler with a 10s periodic export may report metrics more frequently than the OTEL collector's batching interval (also 10s), leading to multiple sets of metrics being pushed to the downstream metrics manager. This can cause Duplicate TimeSeries errors.
Update the counters to push metrics less frequently in periodic export mode, and ensure that metrics are never flushed manually in this mode.
In addition the OTEL collector in unified mode had a 5s default time for batching which is at the limit of the Google Cloud Monitoring requirements that pushes are at least 5s apart.