feat!: Add scaling duration dashboard #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
henrybell
force-pushed
the
henrybell-scaler-metrics-dashboard
branch
from
375af47
to
8aec6bb
Compare
nielm
approved these changes
Jul 10, 2024
|
Consider changing this to a Reason: if anyone is using the metrics, this will break their existing alerts/dashboards |
nielm
requested changes
Jul 10, 2024
BREAKING CHANGE: Update metrics domain for CF to workload.googleapis.com
henrybell
force-pushed
the
henrybell-scaler-metrics-dashboard
branch
from
8aec6bb
to
f23bc72
Compare
henrybell
changed the title
|
Converted to draft pending discussion on when to merge. |
nielm
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additionally updates the metrics domain used by the Cloud Functions deployment from
custom.googleapis.comtoworkload.googleapis.com(to match the GCP Metrics exporter for the OpenTelemetry collector).