Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add opentelemetry tracing #51

Merged
merged 10 commits into from
May 25, 2021
Merged

feat: add opentelemetry tracing #51

merged 10 commits into from
May 25, 2021

Conversation

HemangChothani
Copy link
Contributor

No description provided.

@HemangChothani HemangChothani added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 13, 2021
@HemangChothani HemangChothani removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 15, 2021
@skuruppu skuruppu requested a review from vi3k6i5 April 29, 2021 04:55
larkee
larkee reviewed Apr 29, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests.

Additionally, this does not not yet add tracing. The trace_call needs to be called within the code to create the spans. See here for more context.

larkee
larkee reviewed May 25, 2021
View reviewed changes
google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py Outdated
"db.params": parameters,
"db.instance": cursor.connection.database.name,
}
with trace_call("SpannerSqlAlchemy.Executemany", trace_attributes):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
with trace_call("SpannerSqlAlchemy.Executemany", trace_attributes):
with trace_call("SpannerSqlAlchemy.ExecuteMany", trace_attributes):

larkee
larkee approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the suggestion.

I would like some unit tests for this but they can come later. Please create an issue to track this.

@HemangChothani HemangChothani mentioned this pull request May 25, 2021
Closed
@HemangChothani
Copy link
Contributor Author

Issue for tracking : #76

@HemangChothani HemangChothani merged commit f091a54 into main May 25, 2021
@HemangChothani HemangChothani deleted the opentelemetry_tracing branch May 25, 2021 09:13
@vi3k6i5 vi3k6i5 mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkee larkee larkee approved these changes

@AVaksman AVaksman Awaiting requested review from AVaksman

@IlyaFaer IlyaFaer Awaiting requested review from IlyaFaer

@vi3k6i5 vi3k6i5 Awaiting requested review from vi3k6i5

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HemangChothani @larkee