Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving gRPC benchmark configurations. #58

Open
shileiyu opened this issue Mar 15, 2023 · 2 comments
Open

Improving gRPC benchmark configurations. #58

shileiyu opened this issue Mar 15, 2023 · 2 comments
Assignees

Comments

@shileiyu
Copy link

Is your feature request related to a problem? Please describe.

The benchmark of gRPC framework was collected under less optimal configurations.

  1. WRT unary Echo, the client didn't leverage the ability of multiplexing requests over single HTTP/2 connection.
  2. WRT streaming Echo, There is only one connection has been established, which may lead to head of line problem very quickly.

Comparing KiteX benchmark with those results may misleading developers.

Describe the solution you'd like

  1. At least, explicitly disclose how gRPC benchmarks were collected.
  2. It would be better to have a comparison with results collected under more optimal configurations.
@ppzqh ppzqh self-assigned this Mar 16, 2023
@ppzqh
Copy link

ppzqh commented Mar 16, 2023

Thanks for the feedback. I will try to revise the benchmark description and config.

@YangruiEmma
Copy link
Member

YangruiEmma commented Aug 22, 2024

I just noticed your issue. If you feel that there are problems with the testing code, please feel free to submit PR to help us optimizing it. We would be appreciate it!
Currently, I think the testing methods for Kitex and GRPC are aligned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants