Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed toolbar #167

Closed
Tracked by #169
cloverich opened this issue May 27, 2024 · 0 comments · Fixed by #210
Closed
Tracked by #169

Fixed toolbar #167

cloverich opened this issue May 27, 2024 · 0 comments · Fixed by #210

Comments

@cloverich
Copy link
Owner

cloverich commented May 27, 2024

I attempted to do this in #103 but realized, it should already be doing this based on my Toolbar file:

export const FixedToolbar = withCn(
  Toolbar,
  "supports-backdrop-blur:bg-background/60 sticky left-0 top-[57px] z-50 w-full overflow-x-auto rounded-t-lg border-b border-b-border bg-background/95 backdrop-blur",
);

Most of those classes, including sticky, are not making it to the final build. If I manually add them after, they have no effect. I suspect the associated tailwind classes are not making it into the final product. Since I'm already digging into many things in the other toolbar improvements, IMO makes sense to defer this to when I re-evaluate and adjust all styles in the design sprint. Next steps, I'd look at:

  • How tailwind pre-processor is setup
  • How cn and withCn work
  • Whether radix components are playing a role
  • Whether other CSS packages I have are playing a role (emotion?)
This was referenced May 27, 2024
@cloverich cloverich mentioned this issue Aug 10, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant