Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve note linking search store #227

Open
cloverich opened this issue Sep 1, 2024 · 0 comments
Open

Improve note linking search store #227

cloverich opened this issue Sep 1, 2024 · 0 comments
Labels
refactor Refactoring, tech debt, clean-up - things that would be done if I was less time constrained

Comments

@cloverich
Copy link
Owner

Because of extreme time constraints I implemented note searching in #223 in the laziest way possible, recycling the existing search store. It worked great for the user-facing needs but if / when I ever have more then one-hour blocks to work on the app, or maybe after the key features are shipped, should come back and clean this up

  • Use a custom store or improve (minimize) the interface used by each component
  • Debounce the search
  • Consider how the design will work when its network based (assuming I ever ship hosted notes)
@cloverich cloverich added the refactor Refactoring, tech debt, clean-up - things that would be done if I was less time constrained label Sep 1, 2024
@cloverich cloverich mentioned this issue Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactoring, tech debt, clean-up - things that would be done if I was less time constrained
Projects
None yet
Development

No branches or pull requests

1 participant