Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing around links on their own lines jumps around #46

Closed
Tracked by #68
cloverich opened this issue Sep 18, 2021 · 1 comment
Closed
Tracked by #68

Typing around links on their own lines jumps around #46

cloverich opened this issue Sep 18, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@cloverich
Copy link
Owner

cloverich commented Sep 18, 2021

If a link is on its own line, trying to add text or spaces before or after it produces buggy behavior. The cursor will jump to the next line. Probably related to how the underlying Slate DOM is parsed and converted from MDAST, resulting in invalid node structure. I might investigate adding empty text nodes around them in the normalization phase, or comparing the MDAST and Slate DOM for links on their own lines compared to ones embedded within paragraphs (which don't have this issue) to debug it.

link-space-bug.mp4

Can also see how hitting enter at the end of a link extends the block, so the hover menu thinks it needs to remain open.

Screen Shot 2021-09-20 at 6 26 07 AM

@cloverich
Copy link
Owner Author

No longer an issue after #68 but will be if #81 is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant