Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo better-sqlite3 work-around #66

Closed
cloverich opened this issue Oct 7, 2021 · 1 comment
Closed

Undo better-sqlite3 work-around #66

cloverich opened this issue Oct 7, 2021 · 1 comment

Comments

@cloverich
Copy link
Owner

After upgrading electron and a few other dependencies, better-sqlite3 started failing with a binary incompatibility. Long story short, some upstream mix ups resulted in an incompatible prebuild being used for better-sqlite3. Once fixed, simply upgrading the sqlite3 library and removing the rebuild scripts I added are in order. Adding this issue with links so I can remember to clean this up:

WiseLibs/better-sqlite3#704
WiseLibs/better-sqlite3#694
@cloverich cloverich added the bug Something isn't working label Oct 7, 2021
@cloverich
Copy link
Owner Author

Work-around added in 6de072f

@cloverich cloverich removed the bug Something isn't working label Oct 8, 2021
@cloverich cloverich mentioned this issue Apr 5, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cloverich