Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependabot auto-merge failing #673

Closed
michaelocurtis opened this issue Nov 23, 2021 · 2 comments · Fixed by #680
Closed

dependabot auto-merge failing #673

michaelocurtis opened this issue Nov 23, 2021 · 2 comments · Fixed by #680
Labels
Bug

Comments

@michaelocurtis
Copy link
Contributor

Describe the bug
Dependa auto-merge is failing

To Reproduce
See pulls

Expected behavior
Shouldn't fail auto-merges

Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
Add any other context about the problem here.
@michaelocurtis michaelocurtis changed the title Fix dependabot auto-merge dependabot auto-merge failing Nov 23, 2021
@ChildishGiant
Copy link
Collaborator

This is an issue with the tests (See ZJONSSON/node-unzipper#246) the solution would be changing to another unzipping lib in translation.js

@michaelocurtis
Copy link
Contributor Author

https://www.npmjs.com/package/file-zip-s

A possible replacement - will give it a go later

@michaelocurtis michaelocurtis mentioned this issue Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move to node-stream-zip
2 participants
@ChildishGiant @michaelocurtis