Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare endpoints output as sensitive #9

Merged

Conversation

henworth
Copy link
Contributor

@henworth henworth commented Nov 8, 2021

Description

In Terraform version 0.14 and above, module outputs with sensitive keys need to be marked as sensitive. Currently, this module will error out with this message:

│ Error: Output refers to sensitive values
│
│   on outputs.tf line 84:
│   84: output "endpoints" {
│
│ To reduce the risk of accidentally exporting sensitive data that was
│ intended to be only internal, Terraform requires that any root module
│ output containing sensitive data be explicitly marked as sensitive, to
│ confirm your intent.
│
│ If you do intend to export this data, annotate the output value as
│ sensitive by adding the following argument:
│     sensitive = true
╵

Motivation and Context

Allows apply to complete on Terraform 0.14 and above.

How Has This Been Tested?

Initially observed a Terraform apply fail with the above error message. Once this change was made, the apply was allowed to complete.

Screenshots (if appropriate):

@henworth henworth requested a review from bryantbiggs as a code owner November 8, 2021 16:23
@bryantbiggs bryantbiggs merged commit 179c84b into terraform-aws-modules:main Nov 8, 2021
@bryantbiggs
Copy link
Member

🎉 This PR is included in version 1.0.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

henworth added a commit to henworth/terraform-aws-dms that referenced this pull request Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
@henworth henworth deleted the fix_sensitive_output branch January 20, 2023 20:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants