-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add streaming API #9
Conversation
Also serves as a basis for imageCreate() Emit each progress event via the Promise progress API and resolve Promise with buffered array of all progress events
Looks good! |
Thanks for your feedback! In order to get this in faster, this PR will only address adding a streaming API for existing endpoints, it is not about adding additional endpoints. This PR lacks some documentation. The existing endpoints |
I've just released an early v0.1.0 of clue/tar-react, so I can now continue looking into this PR :) |
Remaining TODOs:
|
I've just added caret notation encoding to the copy/export example, so that dumping binary files does not screw up your terminal. Now getting back to the last missing tests.. |
Also serves as a basis for imagePush()
There you go, I've just completed the last TODOs and removed the WIP marker. Any feedback is very much appreciated! 👍 |
Awesome! I'll try and give it a whirl over the next couple of days! |
Awesome, let me know if you get to this! Two remaining issues:
|
I think this is finally completed 👏 This is a non-trivial feature addition, so this can probably use another review :) |
Either way, let's get this in |
Refs #4