-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to use React / Socket, instead of Socket Client #50
Comments
Thanks for reporting and I agree 👍 I'll have to postpone this for a couple of weeks but will get back to this asap. PRs would also be much appreciated 👍 |
Ty for the quick replay... I'll give the update a go, then I'll make a pull request. |
Hi again - can you please create another branch for version 2.x - Having some issues with you dependencies / mocks, which I'm not the most qualified to resolve. If you create a new branch, I'll make a pull request for it, then you can review the changes. |
I'd rather like to look forward here. May I ask you to just file your PR against the |
Small status update: I've just released an intermediary v1.1.0 release which updates the SocketClient version to the latest version I'll release another intermediary v1.2.0 shortly which also accepts a The major bump to newest components has to be postponed to the v2.0.0 release because we currently expose the legacy |
Small status update: I've just released an intermediary v1.2.0 release which now supports a The major bump to newest component is coming soon-ish 👍 |
Hi Clue
Due to the major changes in react (which you have contributed to), I am sadly no longer able to use the package. The main reason is that this package depends on the
React / SocketClient
package.Can you please update the package's dependencies and release it as version 2.x (important so that you don't break compatibility for those that use version 1.x)
The text was updated successfully, but these errors were encountered: