Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multi-byte UTF-8 characters #12

Closed
clue opened this issue May 14, 2015 · 1 comment · Fixed by #20
Closed

Support multi-byte UTF-8 characters #12

clue opened this issue May 14, 2015 · 1 comment · Fixed by #20
Labels
help wanted new feature

Comments

@clue
Copy link
Owner

clue commented May 14, 2015

Writing multi byte characters (e.g. german umlauts) often looks strange in the readline prompt. The resulting strings reported look fine, though.

Also, moving the cursor around and trying to replace individual characters can end up with invalid byte sequences.
@clue clue mentioned this issue May 14, 2015
Closed
@clue clue changed the title Multi byte characters can end up garbled Support multi-byte UTF-8 characters May 17, 2015
@clue clue added new feature and removed bug labels May 17, 2015
@clue
Copy link
Owner Author

clue commented May 17, 2015

Rephrased this ticket to indicate we never implied we already support UTF-8 - this is actually a new feature request.

@clue clue mentioned this issue May 17, 2015
Merged
@clue clue closed this as completed in #20 May 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support multi-byte UTF-8 characters and account for cell width clue-labs/reactphp-stdio
1 participant
@clue