Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readline does not cope well with long prompt inputs #4

Open
clue opened this issue Sep 9, 2014 · 5 comments
Open

Readline does not cope well with long prompt inputs #4

clue opened this issue Sep 9, 2014 · 5 comments

Comments

@clue
Copy link
Owner

clue commented Sep 9, 2014

No description provided.

@clue clue added the bug label Sep 9, 2014
@clue
Copy link
Owner Author

clue commented May 18, 2015

We can probably use control codes (VT100 anybody?) to get the current terminal size and limit our user input line to the maximum width available. This is non-trivial, but certainly doable. Any other thoughts?

@clue clue added this to the v2.4.0 milestone Aug 19, 2019
@naive17
Copy link

naive17 commented Sep 16, 2019

we can use intval(getenv('COLUMNS')), but i don't think that limiting user input length is the right answer.
Maybe something like nano scrolling line is the way

@clue
Copy link
Owner Author

clue commented Sep 24, 2019

@koso00 Thanks for you input, I agree relying on COLUMNS could be a starting point, but this doesn't completely solve this problem. For instance, we also need to take care of resize events, so I've just filed #92 to keep track of this underlying feature.

Once we know the terminal size, we can limit and/or wrap the user input line.

@naive17
Copy link

naive17 commented Sep 25, 2019

Actually i forked the project, you can see i added mouse events and i'm planning to add resize with the same "way".
you can watch yourself

@clue
Copy link
Owner Author

clue commented Sep 25, 2019

@koso00 Awesome, looking forward to seeing your changes, let's continue this discussion in the dedicated feature tickets #82 and #92.

@clue clue modified the milestones: v2.4.0, v2.5.0 Nov 20, 2020
@clue clue removed this from the v2.5.0 milestone Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants