Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

Indentation with Tabs #135

Closed
niclashoyer opened this issue Jul 8, 2013 · 10 comments
Closed

Indentation with Tabs #135

niclashoyer opened this issue Jul 8, 2013 · 10 comments

Comments

@niclashoyer
Copy link

I'm following the tabs for indentation, spaces for alignment rule in my project. I don't want to bring up the tabs vs. spaces discussion here. It would be nice if I could forbid spaces instead of tabs e.g. something similar to no_tabs like no_spaces.

@JJJollyjim
Copy link

This would be fantastic!

@piot
Copy link

piot commented Oct 12, 2013

Agreed

@AsaAyers
Copy link
Collaborator

If you want to forbid spaces how do you expect spaces for alignment to work?

You may have already found this, but the indentation rule counts characters. Setting the value to 1 will get it to work with tab indentation. A no spaces rule that is the inverse of no tabs would be very simple but prevent alignment.

@AsaAyers
Copy link
Collaborator

After more than a year of not having any feedback on how this should work I'm just going to close it.

@azizhk
Copy link

azizhk commented Jul 24, 2015

Hi @AsaAyers,
Please reopen this issue.

For your question: If you want to forbid spaces how do you expect spaces for alignment to work?
How about for tabs in the beginning of the line, we allow it.
No indentation before any non whitespace characters, but they should be used to allow aligning object declaration.
How does that sound?

@AsaAyers
Copy link
Collaborator

Based on what I've seen here you're the only person who has been interested in this for nearly 2 years. If you want to open a PR for this I'll review it, but I don't see any reason to re-open this. I'm certainly not going to implement this change myself.

@staticshock
Copy link

If you're looking for "activity", I'll chime in. I would use the no_spaces flag if it was available.

@AsaAyers
Copy link
Collaborator

More important than activity is someone who is going to do the work. It only makes sense to re-open this if no one subscribed will do the work and we believe that if the issue is re-opened it will draw the attention of someone else who wants to do this. Given that this is 2 years old and was open for more than a year with no activity at all I just don't think it's going to attract someone who wants to work on this.

@azizhk
Copy link

azizhk commented Jul 24, 2015

Hi,
I completely agree with your thinking, it makes no sense to support feature requests when there is very little popularity 😜

I've tried a sort of hack for it. azizhk#1
Would love if you could review it.
I have not followed the no_spaces flag as it would sound ambiguous, so just modified the indentation module to support a use: 'tabs' option.

I've not created a pull request into your repo as I still have to add test cases, then squash them down to one commit etc.

@laurentpayot
Copy link

+1 for use: 'tabs'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants