Make grpc client creation more flexible

cluttrdev · Feb 26, 2024 · fbd0bf9 · fbd0bf9
1 parent e5e8943
commit fbd0bf9
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/grpc/client/client.go b/grpc/client/client.go
@@ -19,7 +19,7 @@ type Client struct {
 	metrics *grpcprom.ClientMetrics
 }
 
-func NewCLient(addr string, opts ...grpc.DialOption) (*Client, error) {
+func NewCLient(ctx context.Context, target string, opts ...grpc.DialOption) (*Client, error) {
 	metrics := grpcprom.NewClientMetrics( /* opts ...grpcprom.ClientMetricsOption */ )
 
 	opts = append(opts,
@@ -31,7 +31,7 @@ func NewCLient(addr string, opts ...grpc.DialOption) (*Client, error) {
 		),
 	)
 
-	conn, err := grpc.Dial(addr, opts...)
+	conn, err := grpc.DialContext(ctx, target, opts...)
 	if err != nil {
 		return nil, err
 	}

diff --git a/internal/exporter/exporter.go b/internal/exporter/exporter.go
@@ -24,7 +24,7 @@ type EndpointConfig struct {
 func New(endpoints []EndpointConfig) (*Exporter, error) {
 	clients := make(map[string]*grpc_client.Client, len(endpoints))
 	for _, cfg := range endpoints {
-		c, err := grpc_client.NewCLient(cfg.Address, cfg.Options...)
+		c, err := grpc_client.NewCLient(context.Background(), cfg.Address, cfg.Options...)
 		if err != nil {
 			return nil, err
 		}