Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearch sniffing support? #41

Open
pingz opened this issue Mar 21, 2018 · 3 comments
Open

elasticsearch sniffing support? #41

pingz opened this issue Mar 21, 2018 · 3 comments

Comments

@pingz
Copy link

pingz commented Mar 21, 2018

The elasticsearch-py documents recommend turn on sniffing when application is long-running to make sure client is aware of the changes about the cluster location. I think it is worth trying to support it.

ref: https://elasticsearch-py.readthedocs.io/en/master/#sniffing

@cmanaha
Copy link
Owner

cmanaha commented Mar 21, 2018

Makes sense; Setting it as an extra parameter with default to true seems the way to go.
One for next iteration or if anyone would like to pick up that PR.

@pingz pingz mentioned this issue Mar 22, 2018
@pingz
Copy link
Author

pingz commented Mar 22, 2018

@cmanaha thanks for your reply, I've opened PR #42 , would you be kind enough to review it?

@cmanaha
Copy link
Owner

cmanaha commented Mar 23, 2018

Commented on the PR; Hopefully this weekend or the next I'd like to spend some time merging all changes, running tests and checking if there is any additional test we should do (in regards to sniffing). Thanks a lot for your PR's !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants