Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BOOST_FOREACH caches the end() iterator #45

Open
jonblack opened this issue Oct 6, 2014 · 0 comments
Open

BOOST_FOREACH caches the end() iterator #45

jonblack opened this issue Oct 6, 2014 · 0 comments
Labels
bug

Comments

@jonblack
Copy link
Contributor

jonblack commented Oct 6, 2014

BOOST_FOREACH caches the end() iterator and it is undefined behaviour if you modify the container inside the loop.

The affected code is src/structure.cpp:2018.

Either use a standard for loop or the std::remove_if built-in function.
@jonblack jonblack added the bug label Oct 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonblack