New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'operator=' should check for assignment to self #46

Open

jonblack opened this issue Oct 6, 2014 · 0 comments

Labels

Contributor

jonblack commented Oct 6, 2014

'operator=' should check for assignment to self to avoid problems with dynamic memory. The affected code is src/matrix.h:169.

Writing a copy constructor is not trivial. Use the copy-swap idiom. See http://stackoverflow.com/questions/3279543/what-is-the-copy-and-swap-idiom for more details.

jonblack added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment