New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OWMNotFoundException never thrown #150

Closed

robjuz opened this issue Jul 24, 2020 · 0 comments · Fixed by #151

Contributor

robjuz commented Jul 24, 2020

The response is a xml, but the check is for json. Therefore the OWMNotFoundException is never thrown.

OpenWeatherMap-PHP-API/Cmfcmf/OpenWeatherMap.php

Line 586 in c8fa204

    
           if ($result === "{\"message\":\"not found\"}\n" && $response->getStatusCode() === 404) {

robjuz mentioned this issue

Fix 404 Not Found detection #151

Merged

cmfcmf closed this as completed in #151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment