Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WeightCalculatorFromHistogram.cc gives NaN #119

Open
bianchini opened this issue Feb 28, 2019 · 3 comments
Open

WeightCalculatorFromHistogram.cc gives NaN #119

bianchini opened this issue Feb 28, 2019 · 3 comments

Comments

@bianchini
Copy link

https://github.com/cms-nanoAOD/nanoAOD-tools/blob/master/src/WeightCalculatorFromHistogram.cc#L101
initiializes 'cropped' once and then it fills it with while() as many times as needed by thw whil() condition, but checkIntegral() assumes that the length stays the same, so it may give NaN when accessing elements beyond refvals_.size().
@ktht
Copy link
Contributor

ktht commented Mar 14, 2019

I opened a PR about this almost 10 months ago: #87

@arizzi
Copy link
Contributor

arizzi commented Mar 18, 2019

@bianchini can you confirm that #87 works for you and I will merge

@arizzi
Copy link
Contributor

arizzi commented Mar 18, 2019

@fgolf @peruzzim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arizzi @bianchini @ktht