add tracking in StaticAnalyzer of if (cfg.exists or existsAs<Type for psets

[slava77]

one of the pset coding requirements is to not use if (cfg.exists or existsAs<Type.

Here I'm proposing to encode this rule in the StaticAnalyzer so that the issues in the existing code can be found easily.

following https://mattermost.web.cern.ch/cms-o-and-c/pl/q9jr346jrj8xida17iaoywbqbc

[cmsbuild]

A new Issue was created by @slava77 Slava Krutelyov.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[slava77]

@jpata
we talked about this earlier; this is now formalized as an issue

[makortel]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[gartung]

#36424

[makortel]

In CMSSW_12_3_X_2021-12-10-1100 the checker shows 4406 calls
https://cmssdt.cern.ch/SDT/jenkins-artifacts/ib-static-analysis/CMSSW_12_3_X_2021-12-10-1100/slc7_amd64_gcc900/llvm-analysis/index.html

[makortel]

+1

[cmsbuild]

This issue is fully signed and ready to be closed.