-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CloseByPGun Samples Failure #36800
Comments
A new Issue was created by @mdmorris . @Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign generators |
New categories assigned: generators @mkirsano,@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@Saptaparna you have been requested to review this Pull request/Issue and eventually sign? Thanks |
There doesn't appear to be much useful in the traceback
|
Stack trace is
|
I was able to reproduce locally, compiling with
which points to cmssw/IOMC/ParticleGuns/src/CloseByParticleGunProducer.cc Lines 84 to 86 in ec200b2
where PData is nullptr .
|
The process.generator = cms.EDProducer("CloseByParticleGunProducer",
PGunParameters = cms.PSet(
PartID = cms.vint32(22), Adding a printout shows that the failing case has int index = CLHEP::RandFlat::shoot(engine, 0, fPartIDs.size());
int PartID = fPartIDs[index]; I see this part was changed recently in #36460. @lecriste @rovere |
Is this particle gun generator tested in any runTheMatrix workflow or other test in IBs? @cms-sw/pdmv-l2 (if not, would it make sense to make a policy, if there isn't yet, that generators run in RelVals would have to be tested in IBs?) |
Ciao @makortel @Dr15Jones thanks for having looked into that. We will review and submit a fix asap. Ciao and thanks, |
It is also possible to write tests for a specific module using the TestProcessor framework https://github.com/cms-sw/cmssw/tree/master/FWCore/TestProcessor |
@Dr15Jones thanks for the useful pointer. I was not aware of this functionality. |
@rovere sorry about that, could you use TestProcessor framework to trigger the specific test for your PR? I will sign it off if the PR specific test is a success. |
I believe the fix has been merged and is effective since |
@mdmorris @cms-sw/generators-l2 I'm closing this issue. |
The CloseByPGun samples are failing in CMSSW_12_3_0_pre2 (2026D76). I am opening this issue to find the cause of the error., which is linked below. All other HGCAL requested samples completed without failing.
Error: https://cms-unified.web.cern.ch/cms-unified/joblogs/pdmvserv_RVCMSSW_12_3_0_pre2CloseByPGun_CE_H_Coarse_300um__2026D77noPU_220117_164641_2516/139/GenSimFull/68f22295-aa09-40d3-9e92-514fad5f7040-0-3-logArchive/job/WMTaskSpace/cmsRun1/cmsRun1-stdout.log
All CMSSW_12_3_0_pre2 (2026D76) relval samples: https://cms-pdmv.cern.ch/relval/tickets?prepid=*12_3_0_pre2*2026D*&shown=2047&page=0&limit=50
@cms-sw/pdmv-l2 @cms-sw/core-l2
The text was updated successfully, but these errors were encountered: