Noisy Run-3 TopMonitor DQM

[srimanob]

When I try to run Run-3 workflow, I see very noisy warning from TopMornitor DQM. One can check from any PR test, for example, thie recent one.

There are many repeats of

%MSG-w TopMonitor:  TopMonitor:AK8PFJet40 23-Jul-2023 21:26:20 CEST  Run: 1 Event: 1
B-Jet handle not valid, will skip event 

%MSG
%MSG-w TopMonitor:  TopMonitor:PFJet40 23-Jul-2023 21:26:20 CEST Run: 1 Event: 1
B-Jet handle not valid, will skip event 

With my private run, I also see

%MSG
%MSG-w TopMonitor:  TopMonitor:topEleHT_all 24-Jul-2023 16:14:31 CEST  Run: 1 Event: 3
Electron ID handle not valid 

%MSG
%MSG-w TopMonitor:  TopMonitor:topEleHT_ht 24-Jul-2023 16:14:31 CEST  Run: 1 Event: 3
Electron ID handle not valid 

%MSG
%MSG-w TopMonitor:  TopMonitor:topEleHT_ele 24-Jul-2023 16:14:31 CEST  Run: 1 Event: 3
Electron ID handle not valid 

To reproduce the warning, simply run wf 12434.0.

[cmsbuild]

A new Issue was created by @srimanob Phat Srimanobhas.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[srimanob]

assign dqm

[cmsbuild]

New categories assigned: dqm

@tjavaid,@micsucmed,@nothingface0,@rvenditti,@emanueleusai,@syuvivida,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

[mmusich]

This also affects Prompt Reco logs, see #41456 (comment):

• no replies in that issue

[emanueleusai]

@srimanob thank you for the report. We contacted the people responsible for the module and asked to fix the btag/eleID handles.

[mmusich]

@emanueleusai did you hear back from the responsible people?

[emanueleusai]

The TOP conveners are aware of the issue, they mentioned they are currently rebuilding their DQM efforts in top and will make sure the issues are fixed. Perhaps this should be further coordinated with the current DQM conveners. I am still taking care of PR reviews, but my DQM convener term has ended.

[srimanob]

Hi @mmusich

I've provided the fix in #42808. It comes from BTV HLT module. Not sure why they never complain on empty histograms.

It will need confirmation from @cms-sw/hlt-l2 @missirol if fix is done properly. Thx.

[mmusich]

It comes from BTV HLT module. Not sure why they never complain on empty histograms.

@cms-sw/btv-pog-l2 FYI... this sounds familiar (at least seems it was discussed at the last BTV workshop)?

[mmusich]

Thanks @srimanob as a further action item I would suggest to rename the B-tagging HLT monitoring modules to make it a little bit clearer who owns them (right now they just state the name of the monitored path):

cmssw/DQMOffline/Trigger/python/BTaggingMonitoring_cff.py

Lines 190 to 195 in a17512e

	btvHLTDQMSourceExtra = cms.Sequence(
	PFJet40
	+ AK8PFJet40
	+ PFJetFwd40
	+ AK8PFJetFwd40
	)

[srimanob]

Hi @mmusich
I can include in my PR, i.e. changing PFJet40 to BTagPFJet40 or BTagMonitorPFJet40 if this is ok.

[mmusich]

BTagMonitorPFJet40

This sounds good to me (of course @cms-sw/btv-pog-l2 need to approve the change)

[missirol]

It will need confirmation from https://github.com/orgs/cms-sw/teams/hlt-l2 @missirol if fix is done properly. Thx.

Fwiw, #42808 looks good to me. Thanks @srimanob !

[SWuchterl]

@mmusich Thanks for notifying!
And @srimanob, thank you for the fix! #42808 looks good to me, too.
Renaming the modules sounds also reasonable to me.

[mmusich]

@cms-sw/dqm-l2 this issue is ready to be signed after #42808 got merged.

[emanueleusai]

+1

[cmsbuild]

This issue is fully signed and ready to be closed.