Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2] Test TestDQMOfflineConfigurationGotAll fails #42831

Open
iarspider opened this issue Sep 20, 2023 · 5 comments
Open

[13_2] Test TestDQMOfflineConfigurationGotAll fails #42831

iarspider opened this issue Sep 20, 2023 · 5 comments

Comments

@iarspider
Copy link
Contributor

Test TestDQMOfflineConfigurationGotAll in DQMOffline/Configuration is failing at least since CMSSW_13_2_X_2023-09-14-2300:

===== Test "TestDQMOfflineConfigurationGotAll" ====
DQM:offlineHLTSourceOnAODextra
entry file:///data/cmsbuild/jenkins_a/workspace/ib-run-qa/CMSSW_13_2_X_2023-09-14-2300/tmp/004D960A-EA4C-E811-A908-FA163ED1F481.root
Step: DQM Spec: ['offlineHLTSourceOnAODextra']
Config file cmssw_cfg.py created

---> test TestDQMOfflineConfigurationGotAll had ERRORS
TestTime:258
^^^^ End Test TestDQMOfflineConfigurationGotAll ^^^^

The test runs the following command:

cmsswSequenceInfo.py --runTheMatrix --steps DQM,VALIDATION --infile file://${LOCALTOP}/tmp/${INFILE_NAME} --limit 50 --offset 300 --threads 1

and expects it to output Analyzing 0 seqs, but the actual output is Analyzing 1 seqs

@cmsbuild
Copy link
Contributor

A new Issue was created by @iarspider .

@Dr15Jones, @rappoccio, @smuzaffar, @makortel, @sextonkennedy, @antoniovilela can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

assign dqm

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@tjavaid,@micsucmed,@nothingface0,@rvenditti,@emanueleusai,@syuvivida,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mmusich
Copy link
Contributor

mmusich commented Oct 11, 2023

by trial and error I found out that this issue exists in CMSSW_13_2_4 but not in CMSSW_13_2_3.
Reverting locally #42714 (more specifically just commit 5e21e71) the failure disappears.

@mmusich
Copy link
Contributor

mmusich commented Oct 11, 2023

with this

diff --git a/DQMOffline/Configuration/test/BuildFile.xml b/DQMOffline/Configuration/test/BuildFile.xml
index 4334126214c..3c88e75f054 100644
--- a/DQMOffline/Configuration/test/BuildFile.xml
+++ b/DQMOffline/Configuration/test/BuildFile.xml
@@ -10,6 +10,6 @@
 
 <!-- To make sure we actually got all sequences, the last check checks that there are no sequences beyond the last test -->
 <!-- This might need to updated when the number of distinct sequences grows, add more rows above and change the number here. -->
-<test name="TestDQMOfflineConfigurationGotAll" command="cmsswSequenceInfo.py --runTheMatrix --steps DQM,VALIDATION --infile file://${LOCALTOP}/tmp/${INFILE_NAME} --limit 50 --offset 300 --threads 1 | grep 'Analyzing 0 seqs'">
+<test name="TestDQMOfflineConfigurationGotAll" command="cmsswSequenceInfo.py --runTheMatrix --steps DQM,VALIDATION --infile file://${LOCALTOP}/tmp/${INFILE_NAME} --limit 50 --offset 301 --threads 1 | grep 'Analyzing 0 seqs'">
   <flags PRE_TEST="GetTestDQMOfflineConfigurationFile"/>
 </test>

the problem goes away. TBH I have no idea how the offset and limits are decided. @cms-sw/dqm-l2 please clarify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants