[LLVM Analyzer] Called C++ object pointer is null in JetResolution::parameterEtaEval

[iarspider]

LLVM analyzer reports.

If parameter is not found, besides printing error on L182-184, should the function return some special value or should the execution terminate?

[iarspider]

assign CondFormats/JetMETObjects

[cmsbuild]

New categories assigned: db

@francescobrivio,@saumyaphor4252,@perrotta,@consuegs you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

cms-bot internal usage

[cmsbuild]

A new Issue was created by @iarspider.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[perrotta]

If parameter is not found, besides printing error on L182-184, should the function return some special value or should the execution terminate?

@iarspider taking into account that, as far as I remember, such an error never showed up it will quite likely change nothing.
In any case, I think that the logic should be that if the func is not found, one should terminate (maybe with an assert, if you want to get rid of the warning in the LLVM analyzer.
The alternative of putting a default return value (1., for 100% resolution as default?) is leading in my opinion to potential mistakes and unneeded processing of wrong configs if the LogError message remains unnoticed.

[Dr15Jones]

How about throwing an exception?