Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please avoid node dependency to "natives" module #68

Closed
bpasero opened this issue Apr 10, 2018 · 3 comments
Closed

Please avoid node dependency to "natives" module #68

bpasero opened this issue Apr 10, 2018 · 3 comments

Comments

@bpasero
Copy link

bpasero commented Apr 10, 2018

Hi,

I am a developer on VSCode and wanted to reach out to inform you that this extension is either using or having a dependency to a node module "natives" that will soon no longer be supported in VSCode once we updated to node.js 8.x (as part of our Electron 2.0 update which is planned for the near term).

The full graph is:

└─┬ gulp@3.9.1
  └─┬ vinyl-fs@0.3.14
    └─┬ graceful-fs@3.0.11
      └── natives@1.1.0 

It would be great if this dependency could be avoided by either not depending on it anymore or updating the dependencies to newer versions so that this module is no longer pulled in.

As soon as any code in your extension (including node_modules) calls require("natives") we will throw an exception to prevent this module from getting loaded.

If this is just a devDependency and the module is never loaded in production, then you can ignore this issue and just close it!

More details in microsoft/vscode#47569

Thanks!
Ben
VSCode Team

@cmstead
Copy link
Owner

cmstead commented Apr 13, 2018

Hey Ben,

Thanks for the heads up, It looks like natives is a dependency of Gulp which is not part of the distribution, just part of the testing story, so I don't anticipate this causing any issues.

I'll verify that Gulp isn't declared in the distribution dependencies (since it is dev only) and update if needed.

I really appreciate you reaching out.

@bpasero
Copy link
Author

bpasero commented Apr 16, 2018

@cmstead thank you, if gulp is not part of the distribution then there would be nothing to do here 👍

@cmstead
Copy link
Owner

cmstead commented May 1, 2018

I reorganized the dependencies, so everything should be nice and clean. Closing out.

@cmstead cmstead closed this as completed May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants