Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix license headers and file identifications #281

Open
skyzh opened this issue Aug 25, 2022 · 3 comments
Open

docs: fix license headers and file identifications #281

skyzh opened this issue Aug 25, 2022 · 3 comments

Comments

@skyzh
Copy link
Member

skyzh commented Aug 25, 2022

The style for header of each file is not consistent across all files in the project. The copyright date isn't updated to 2022. We should figure out a template for all of our file headers and fix this.

This is the style mostly found in this project:

//===----------------------------------------------------------------------===//
//
//                         BusTub
//
// rid.h
//
// Identification: src/include/common/rid.h
//
// Copyright (c) 2015-2019, Carnegie Mellon University Database Group
//
//===----------------------------------------------------------------------===//
@lmwnshn
Copy link
Collaborator

lmwnshn commented Aug 25, 2022

I think there is a script somewhere that did this formatting.

@skyzh
Copy link
Member Author

skyzh commented Aug 25, 2022

Unluckily, the only .sh file in this repo is build_support/packages.sh. Do you mean some tools outside of this repo?

@lmwnshn
Copy link
Collaborator

lmwnshn commented Aug 29, 2022

Sorry, I'm bad at checking github notifs.

I don't remember if we have a newer version than Peloton, which is basically just a dumb header regex anyway.

I'm inclined to not care about this and punt to the future now that the semester is underway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants