-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GeoMapper produces invalid counties >80000 for JHU #318
Comments
Ah these are likely coming from the Puerto Rico 72888 and 72999 UIDs, will take a look. |
I've been meaning to make a unified map of all the hand modifications we use in JHU, it might be time. |
So do we need to enforce this in GeoMapper or do we need to have some/all indicators check this later? |
@sgsmob Since this a global requirement for all indicators, I think we should enforce it once in GeoMapper. |
Ah I see, these are not Puerto Rico, but are the Princess Cruises ships. @sgsmob this is the JHU UID lookup file from this repo.
We just need to make sure they are dropped from the JHU UID -> FIPS mapping file. Should be a few lines. |
Also the high-level GeoMapper docs are here. The section on geo codes provides general info on the codes we support and the section on source files describes the authorities we get the lookup tables from. |
Reproducing my table of custom JHU UID -> FIPS mappings:
|
Specifically,
88888
and99999
. COVIDcast fails any county file with a geo over 80000, so that's not allowed.This might be related to the 800XX and 900XX codes referenced here and here; JHU plays pretty fast and loose with their geo coding. It's totally fine for GeoMapper to use 8xxxx and 9xxxx codes internally for geo aggregation, we just can't let them escape into CSV files destined for COVIDcast ingestion.
@dshemetov would you introduce @sgsmob to the relevant code and documentation here and on JHU's github?
The text was updated successfully, but these errors were encountered: