[Backfill corrections] Restore original params if pipeline exits with an error

[nmdefries]

Description

Modify params dirs (for convenience of working with user-provided paths) only inside the docker container so that the original user-provided params file is preserved regardless of pipeline exit status or other unintended behavior.

Changelog

• Makefile

Fixes

Previously modifications to dir paths were performed on the original params.json outside the docker container. Restoring it to its original state relied on a teardown step that didn't run if the pipeline exited with an error.

Instead of solving this by capturing and rethrowing errors, it was easier to limit params modifications to a copy of the mounted params.json inside the docker container. The copy is not linked to any file on the host, so changes to it are not propagated back to the original params.json.

I can't find any built-in support for mounting a file from the host but NOT propagating in-container changes back to the host, so params.json is mounted under another name and then copied manually.

[krivard]

Nice find! It's always great when you can drop a target without loss of functionality.

Suggestion optional; probably works either way.

[nmdefries]

@krivard This is ready to merge