-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert covidcast signal OR clauses to UNION #1021
Conversation
…auses to UNION 2. Edited test_query.py for testing filter_source_signal_pairs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is your first major change to the code, so I was pickier than I would otherwise be.
a few logic confirmations which need to be addressed before approval, but mostly style suggestions
also: are the filter_X
equivalents to the new alternative_filter_X
functions being used anymore? If not we can just drop them.
if conditions: | ||
for condition in conditions: | ||
condition_array.append(f"({source_field} = :{source_param} AND {condition})") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking my understanding: this block will always execute, since conditions
will always evaluate true: alternative_filter_strings
wraps alternative_filter_values
, and alternative_filter_values
returns either a nonempty string ("False"
) or a nonempty list (a function of pair.signal
)
Is that right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am reasonably satisfied, but I'm looping in Dmitry and George on this since it conflicts/interacts with a possible solution to a problem they're solving in an upcoming feature release for just-in-time processing.
The issue this was intended to address (#763) is no longer relevant, so i am closing this PR. |
closes #763
Prerequisites:
dev
branchdev
Summary