-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design and enforce linting standards #962
Comments
Looking at the |
I'll also throw out that I'm pretty partial to The biggest selling point for me is the time-saving: often the solution to To be fair, sometimes it really struggles and removes clearly human-readable formatting. But I think most of those can be mitigated by a judicious use of the |
for posterity, the above-referenced mention is here: #1041 (comment) |
Formatting work
|
https://github.com/cmu-delphi/covidcast-indicators has nice linting requirements (here is an example pylint file), and we deserve nice things over here too.
To do it the same way that
indicators
does, we'd need to either figure out how to lint a mixed tree of python files or convertacquisition
andserver
to actual legit python modules. Then we just add pylint commands to CI.We don't have to do it the same way that
indicators
does though. Alternatives?The text was updated successfully, but these errors were encountered: