Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor *_population_scaling() #234

Closed
5 tasks
Tracked by #318
dajmcdon opened this issue Sep 12, 2023 · 0 comments · Fixed by #373
Closed
5 tasks
Tracked by #318

refactor *_population_scaling() #234

dajmcdon opened this issue Sep 12, 2023 · 0 comments · Fixed by #373

Comments

@dajmcdon
Copy link
Contributor

dajmcdon commented Sep 12, 2023 •
edited
Loading

  • Improve messages / warnings
  • Use dplyr::join_by() correctly
  • Better approach or name for df_pop_col
  • style the code
  • tests need to be updated (currently suppressing multiple messages/warnings). Mostly related to join = NULL auto-joining.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

352 remove all instances of epi keys cmu-delphi/epipredict
1 participant
@dajmcdon