Skip to content

Remove issue queries for 7dav data #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Oct 11, 2022 · 5 comments
Closed

Remove issue queries for 7dav data #230

brookslogan opened this issue Oct 11, 2022 · 5 comments
Labels
P2 low priority

Comments

@brookslogan
Copy link
Contributor

Eventually queries for 7dav issue (but not as_of) data will be going away, and we'll want to use slides / caching derived archives to calculate them anyway. We should change all (archive) data objects, examples, vignettes, etc. to avoid these queries. Also check epipredict.

@brookslogan brookslogan added the P0 high priority label Oct 11, 2022
@brookslogan
Copy link
Contributor Author

Performing this calculation intelligently (without repeatedly recalculating 7dav's that haven't changed) will require some of the same logic as developed in server-side JIT. We would also want to compactify along the way as in #173.

@brookslogan
Copy link
Contributor Author

JIT isn't happening soon; we want this instead to give correct results on some signals with bad 7dav data, or just for the functionality.

@brookslogan
Copy link
Contributor Author

We probably don't need this for any of the current vignettes.

@brookslogan brookslogan added P2 low priority P1 medium priority and removed P0 high priority P1 medium priority labels Oct 24, 2023
@dshemetov
Copy link
Contributor

Closing as outdated.

@brookslogan
Copy link
Contributor Author

This is still sort of relevant due to potentially-buggy vignette data cmu-delphi/epidatasets#9, but I think we have the required archive -> archive transforms probably in some other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 low priority
Projects
None yet
Development

No branches or pull requests

3 participants