-
Notifications
You must be signed in to change notification settings - Fork 8
One more simple example for getting start guide #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@ryantibs, I can do it. I tried to install the package as indicated in the getting started guide but I get what seems to be a permission error related to
Is that expected to happen and I should manually run the functions? |
Thanks! Re that error: my guess is that it's because of these two lines at the bottom of the DESCRIPTION file:
I think that was added by @lcbrooks but it's possible there was a merge conflict somewhere that messed them up. So you could either fix the reference to the Either way, you could commit this change to your PR with the new example, and then when we merge it in, it'll fix main as well. |
By the way, you could just build the package locally, and you shouldn't get that problem --- I have never gotten that problem with a local build, but I did recreate that problem by calling |
I think the issue here may be that the Remotes entry should have "github::"
rather than "github:". Will need to test to make sure. Sorry for the
trouble.
[EDIT: actually, this was a typo in the delphi-epidata-r package. It can be resolved via installing with
```
devtools::install_github("cmu-delphi/delphi-epidata-r", ref="fix-rbuildignore-makefile-typo")
```
but Ryan has already updated the guide to use a the `covidcast` package instead.]
|
Thanks, I'm running it locally and I'll let you know when I'm done |
@ryantibs, can you give me permission to push to the repo? |
Sure, I just gave you write access. Just so you know, you should be able to create a fork and submit a PR even without write access. And in any case you should always be creating a branch (or fork) and submitting a PR for new developments, in case that wasn't clear. Thanks! |
Great, thanks. I cloned and created a new branch and now I'll open the PR. |
Closed via #43. |
We should add more more example at the bottom of the getting started guide (there's a "todo" at the bottom to mark the spot).
I'm thinking it'd be nice to have one more example just getting some data into
epi_df
format and then plotting it. Can be something from theoutbreaks
package, or something from the web somewhere (but not fromcovidcast
).cc @rafaelcatoia @qpmnguyen In case you guys are interested.
The text was updated successfully, but these errors were encountered: