Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

too-long Region Details chart titles get cut off #656

Closed
krivard opened this issue Nov 30, 2020 · 2 comments
Closed

too-long Region Details chart titles get cut off #656

krivard opened this issue Nov 30, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@krivard
Copy link
Contributor

krivard commented Nov 30, 2020

Actual Behavior:

The chart titles for cases & deaths don't fit in the Region Details chart width. Cuts off at:

  • Newly reported COVID-19 cases (7-day average) -> Newly reported COVID-19 cases (7-day ave
  • Newly reported COVID-19 deaths (7-day average) -> Newly reported COVID-19 deaths (7-day av

Steps to Reproduce the Bug:

  1. go to https://dev--cmu-delphi-main.netlify.app/covidcast/?sensor=doctor-visits-smoothed_adj_cli&level=county&date=20201126&signalType=value&encoding=color&mode=single&region=42003
  2. Examine charts for "Newly reported COVID-19 cases (7-day average)" and "Newly reported COVID-19 deaths (7-day average)"

Expected behavior

Any of the following would be fine:

  • Reduce the number of characters in the indicator's MapTitleText (@RoniRos or someone in comms)
  • Reduce the font size of the title so the full text fits
  • "Newly reported COVID-19 deaths (7-day..." + tooltip with full text of title

Screenshots

image

Rating Scale (1 is minor, 7 is severe): 2? The operative part (cases; deaths) is legible, and if you click the ? you get the full pop-up description which includes the full title text.

Context

  • Browser: Chrome 87.0.4280.67 on a Mac
@krivard krivard added the bug Something isn't working label Nov 30, 2020
@dlaliberte
Copy link
Contributor

Thanks for reporting this. I knew about it when I made the change that stabilized the layout. Previously, it was wrapping the title, which overwrote the value displayed on the next line, which I thought looked much worse. I would suggest changing "Newly reported" to just "New", which is consistent with what we are showing now in the Details panel legend at the bottom.

@dlaliberte
Copy link
Contributor

I fixed this by only changing the font size, making the header bold (because it is soo small, it needed a little more emphasis), and cleaning up other whitespace, especially the key table layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants