Merge pull request #97 from cnblogs/use-aggregate-exception

feat: throw aggregate exceptions when publishing domain event

Author: ikesnowy

src/Cnblogs.Architecture.Ddd.Domain.Abstractions/DomainEvent.cs

@@ -1,11 +1,9 @@
-using MediatR;
-
-namespace Cnblogs.Architecture.Ddd.Domain.Abstractions;
+namespace Cnblogs.Architecture.Ddd.Domain.Abstractions;
 
 /// <summary>
 ///     领域事件基类。
 /// </summary>
-public abstract record DomainEvent : IDomainEvent, INotification
+public abstract record DomainEvent : IDomainEvent
 {
     /// <summary>
     ///     领域事件生成时间。

src/Cnblogs.Architecture.Ddd.Infrastructure.Abstractions/DispatchDomainEventExtensions.cs

@@ -1,4 +1,3 @@
-using System.Runtime.ExceptionServices;
 using Cnblogs.Architecture.Ddd.Domain.Abstractions;
 
 // ReSharper disable once CheckNamespace
@@ -16,7 +15,7 @@ public static class DispatchDomainEventExtensions
     /// <param name="events">要发布的领域事件。</param>
     public static async Task DispatchDomainEventsAsync(this IMediator mediator, IEnumerable<IDomainEvent> events)
     {
-        Exception? e = null;
+        List<Exception>? exceptions = null;
         foreach (var domainEvent in events)
         {
             try
@@ -25,13 +24,14 @@ public static async Task DispatchDomainEventsAsync(this IMediator mediator, IEnu
             }
             catch (Exception exception)
             {
-                e ??= exception;
+                exceptions ??= new List<Exception>();
+                exceptions.Add(exception);
             }
         }
 
-        if (e is not null)
+        if (exceptions?.Count > 0)
         {
-            ExceptionDispatchInfo.Capture(e).Throw();
+            throw new AggregateException(exceptions);
         }
     }
 }

test/Cnblogs.Architecture.UnitTests/Infrastructure/EntityFramework/BaseRepositoryTests.cs

@@ -90,7 +90,7 @@ public async Task GetEntityAsync_ThenInclude_NotNullAsync()
     }
 
     [Fact]
-    public async Task SaveEntitiesAsync_CallBeforeUpdateForRelatedEntityAsync()
+    public async Task SaveEntitiesAsync_CallBeforeUpdateForRelatedEntity_UpdateDateUpdatedAsync()
     {
         // Arrange
         var entity = new EntityGenerator<FakeBlog>(new FakeBlog())
@@ -118,7 +118,7 @@ public async Task SaveEntitiesAsync_CallBeforeUpdateForRelatedEntityAsync()
     }
 
     [Fact]
-    public async Task SaveEntitiesAsync_DispatchEntityDomainEventsAsync()
+    public async Task SaveEntitiesAsync_DispatchEntityDomainEvents_DispatchAllAsync()
     {
         // Arrange
         var entity = new EntityGenerator<FakeBlog>(new FakeBlog())
@@ -156,7 +156,7 @@ public async Task SaveEntitiesAsync_DispatchEntityDomainEventsAsync()
     }
 
     [Fact]
-    public async Task SaveEntitiesAsync_DispatchRelatedEntityDomainEventsAsync()
+    public async Task SaveEntitiesAsync_DispatchRelatedEntityDomainEvents_DispatchAllAsync()
     {
         // Arrange
         var entity = new EntityGenerator<FakeBlog>(new FakeBlog())
@@ -195,7 +195,7 @@ public async Task SaveEntitiesAsync_DispatchRelatedEntityDomainEventsAsync()
     }
 
     [Fact]
-    public async Task SaveEntitiesAsync_DispatchEntityDomainEventsWithGeneratedIdAsync()
+    public async Task SaveEntitiesAsync_DispatchEntityDomainEventsWithGeneratedId_DispatchAllAsync()
     {
         // Arrange
         var entity = new EntityGenerator<FakeBlog>(new FakeBlog())
@@ -228,4 +228,44 @@ public async Task SaveEntitiesAsync_DispatchEntityDomainEventsWithGeneratedIdAsy
                 It.IsAny<CancellationToken>()),
             Times.Exactly(entity.Posts.Count));
     }
+
+    [Fact]
+    public async Task SaveEntitiesAsync_DispatchEntityDomainEventsWithMultipleExceptions_ThrowAggregateExceptionsAsync()
+    {
+        // Arrange
+        var entity = new EntityGenerator<FakeBlog>(new FakeBlog())
+            .Setup(x => x.DateUpdated = DateTimeOffset.Now.AddDays(-1))
+            .HasManyForEachEntity(
+                x => x.Posts,
+                x => x.Blog,
+                new EntityGenerator<FakePost>(new FakePost()).Setup(
+                    x => x.DateUpdated = DateTimeOffset.Now.AddDays(-1)))
+            .GenerateSingle();
+        var db = new FakeDbContext(
+            new DbContextOptionsBuilder<FakeDbContext>().UseInMemoryDatabase("inmemory").Options);
+        var mediator = new Mock<IMediator>();
+        mediator.Setup(x => x.Publish(It.IsAny<IDomainEvent>(), It.IsAny<CancellationToken>()))
+            .Throws<ArgumentException>();
+        var repository = new TestRepository(mediator.Object, db);
+
+        // Act
+        entity.AddDomainEvent(id => new FakeDomainEvent(id, 1));
+        entity.Posts.ForEach(x => x.AddDomainEvent(id => new FakeDomainEvent(id, 2)));
+        var act = async () => await repository.AddAsync(entity);
+
+        // Assert
+        var eventCount = 1 + entity.Posts.Count;
+        (await act.Should().ThrowAsync<AggregateException>()).And.InnerExceptions.Should()
+            .HaveCount(eventCount);
+        mediator.Verify(
+            x => x.Publish(
+                It.Is<IDomainEvent>(d => ((FakeDomainEvent)d).Id != 0 && ((FakeDomainEvent)d).FakeValue == 1),
+                It.IsAny<CancellationToken>()),
+            Times.Once);
+        mediator.Verify(
+            x => x.Publish(
+                It.Is<IDomainEvent>(d => ((FakeDomainEvent)d).Id != 0 && ((FakeDomainEvent)d).FakeValue == 2),
+                It.IsAny<CancellationToken>()),
+            Times.Exactly(entity.Posts.Count));
+    }
 }