Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLAbot is lacking logs #26

Closed
dims opened this issue Jan 23, 2019 · 14 comments
Closed

CLAbot is lacking logs #26

dims opened this issue Jan 23, 2019 · 14 comments

Comments

@dims
Copy link
Member

dims commented Jan 23, 2019

This is especially painful when doing git surgery, examples

Let's take an example - kubernetes/utils#55, the bot says:
cla/linuxfoundation — dims authorized, but 1 other problem

and the Details link points to https://identity.linuxfoundation.org/projects/cncf which is not helpful as we should not be pinging the helpdesk to figure out which git commit in a PR is causing an issue.

Can we please do better?

  • log exactly why the bot thinks the PR is bad
  • link to logs, so we can go look at the verbose output from the bot
@dims
Copy link
Member Author

dims commented Jan 23, 2019

kind of related to #3

@dims
Copy link
Member Author

dims commented Jan 23, 2019

currently the only way in k/k repos is to run the prow /override command by an admin to clear the bot status (tip courtesy of @BenTheElder)

@idvoretskyi
Copy link
Member

cc @caniszczyk @idvoretskyi

@dankohn
Copy link
Contributor

dankohn commented Jan 23, 2019

@dims We are ready to replace the old CLAbot with a newly developed one. One of the big strengths is that it will be open source. So, while I'm sure it will have some new (and different bugs), it should be feasible to resolve them much faster.

I had some hesitation on rolling out to Kubernetes first, and was hoping to use gRPC as our beta tester. If you feel differently, we could swap that around. Either way, we would love your help if you would be willing to take a look at what we have built.

Cc @ShubhraKar

@ShubhraKar
Copy link

@dims please let me know if you want to preview the new CLA tool. Happy to share.

@dims
Copy link
Member Author

dims commented Jan 23, 2019

@ShubhraKar sure! yes please

@ShubhraKar
Copy link

Could you please provide your email or send me a note on skar@linuxfoundation.org so that I can schedule a meeting? Anyone else we should be inviting to the preview @dims @dankohn ?

@thisisnotapril
Copy link

@dankohn FWIW, gRPC would be happy to be the beta tester as well!

@dankohn
Copy link
Contributor

dankohn commented Jan 23, 2019

That's great to hear, @thisisnotapril. We'd like to provide a demo for you as well. We don't want to switch over until you say it's ready, but gRPC is lower volume and so would make sense to start with.

@jpalmerLinuxFoundation
Copy link

@dims I shared some quick mockups for you regarding the logs. Just want to get some feedback going so I can understand the need better: communitybridge/easycla#169

@caniszczyk
Copy link
Contributor

all issues should go to https://github.com/communitybridge/easycla

@dims
Copy link
Member Author

dims commented Feb 16, 2021

This is still not fixed for kubernetes ... kubernetes/kubernetes#98735 (comment)

@caniszczyk can you please reopen this?

@caniszczyk
Copy link
Contributor

@dims leaving this closed and instead opening the issue here for you communitybridge/easycla#2664

EasyCLA team will take it over, less a CNCF thing and more an EasyCLA issue

@dims
Copy link
Member Author

dims commented Feb 16, 2021

@caniszczyk thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants