fix: avoid db query on sync mode all #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ctx.redirect(downloadUrl); | ||
| return; | ||
| } | ||
|
|
||
| // check package version in database | ||
| const pkg = await this.getPackageEntityByFullname(fullname); | ||
| const packageVersion = await this.getPackageVersionEntity(pkg, version); |
There was a problem hiding this comment.
此代码 patch 主要是增加了一个条件判断和对对应业务的处理：
- 新增 import 语句导入 SyncMode 常量。
- 在 download 方法中新增对变量 this.config.cnpmcore.syncMode 的判断，如果该值等于 SyncMode.all 且下载链接存在，会先使用该下载链接以避免数据库查询，然后增加包版本计数器（这里的具体实现需要结合其他代码进行评估），最后进行重定向。
- 如果不存在下载链接，则继续检查数据库中是否存在对应的包和版本记录。根据语境，该方法在用户请求下载时会调用。
评估该 patch 后可能含有的缺陷和改进建议：
- 需要确认 SyncMode.all 判断条件的意义和设计合理性
- 涉及到 packageManagerService.plusPackageVersionCounter() 功能的实现需要确认其正确性和是否遗漏其他关键操作（例如异常处理、事务等）
- 需要补充注释来解释相关意思和解释该 patch 是出于何种原因而做出的
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
==========================================
- Coverage 97.00% 96.97% -0.03%
==========================================
Files 174 174
Lines 16538 16545 +7
Branches 2162 2163 +1
==========================================
+ Hits 16043 16045 +2
- Misses 495 500 +5
|
fengmk2
pushed a commit
that referenced
this pull request
Jun 20, 2023
[skip ci] ## [3.34.4](v3.34.3...v3.34.4) (2023-06-20) ### Bug Fixes * avoid db query on sync mode all ([#527](#527)) ([49855d9](49855d9)), closes [/github.com//pull/522/files#r1234655574](https://github.com/cnpm//github.com/cnpm/cnpmcore/pull/522/files/issues/r1234655574)
|
恢复了，每次都查询 db 支撑不住，并发请求 tcp 连接数达到峰值 |
hezhengxu2018
pushed a commit
that referenced
this pull request
Jun 20, 2023
hezhengxu2018
pushed a commit
that referenced
this pull request
Jun 20, 2023
[skip ci] ## [3.34.4](v3.34.3...v3.34.4) (2023-06-20) ### Bug Fixes * avoid db query on sync mode all ([#527](#527)) ([49855d9](49855d9)), closes [/github.com//pull/522/files#r1234655574](https://github.com/cnpm//github.com/cnpm/cnpmcore/pull/522/files/issues/r1234655574)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/cnpm/cnpmcore/pull/522/files#r1234655574