fix: console #534
Merged
fix: console #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -94,7 +94,6 @@ export class SavePackageVersionController extends AbstractController { | |||
| // if pkg already exists, still allow to publish | |||
| const [ scope, name ] = getScopeAndName(fullname); | |||
| const pkg = await this.packageRepository.findPackage(scope, name); | |||
| console.log('pkg', pkg); | |||
| if (!pkg) { | |||
| const errors = (validateResult.errors || validateResult.warnings).join(', '); | |||
| throw new UnprocessableEntityError(`package.name invalid, errors: ${errors}`); | |||
There was a problem hiding this comment.
这段代码的修改内容相对较少，主要是删除了一行console.log('pkg', pkg);语句。从代码安全和性能优化角度考虑，去掉这行调试信息并不会带来什么风险或者显著的改进。
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
==========================================
- Coverage 97.03% 96.98% -0.06%
==========================================
Files 174 174
Lines 16561 16560 -1
Branches 2171 2167 -4
==========================================
- Hits 16070 16060 -10
- Misses 491 500 +9
|
fengmk2
pushed a commit
that referenced
this pull request
Jun 27, 2023
[skip ci] ## [3.34.9](v3.34.8...v3.34.9) (2023-06-27) ### Bug Fixes * console ([#534](#534)) ([4141003](4141003))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
去除 console.log