Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: author info #581

Merged
merged 1 commit into from
Sep 1, 2023
Merged

fix: author info #581

merged 1 commit into from
Sep 1, 2023

Conversation

elrrrrrrr
Copy link
Member

@elrrrrrrr elrrrrrrr commented Sep 1, 2023 •
edited
Loading

in npm@8 cli, empty author information after executing npm search

  • 🐞 Fix: npm-cli author field is empty, need to add publisher-related fields
  • 📚 Update API documentation

npm@8 命令行，执行 npm search 后，author 信息为空

  • 🐞 修复 npm-cli author 字段为空，需添加 publisher 相关字段
  • 📚 更新文档接口信息

image

@elrrrrrrr elrrrrrrr added bug Something isn't working documentation Improvements or additions to documentation labels Sep 1, 2023
@elrrrrrrr elrrrrrrr requested review from fengmk2 and Beace September 1, 2023 03:16
@codecov
Copy link

codecov bot commented Sep 1, 2023 •
edited
Loading

Codecov Report

Merging #581 (79617e3) into master (bcf67c4) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #581   +/-   ##
=======================================
  Coverage   96.93%   96.94%           
=======================================
  Files         180      180           
  Lines       17344    17356   +12     
  Branches     2249     2249           
=======================================
+ Hits        16813    16825   +12     
  Misses        531      531
Files Changed Coverage Δ
app/core/service/PackageSearchService.ts 93.75% <100.00%> (+0.23%) ⬆️
app/repository/SearchRepository.ts 100.00% <100.00%> (ø)

@fengmk2 fengmk2 merged commit 6dd241d into master Sep 1, 2023
@fengmk2 fengmk2 deleted the fix-author branch September 1, 2023 03:23
fengmk2 pushed a commit that referenced this pull request Sep 1, 2023
@semantic-release-bot
Release 3.43.2
3f95d0f 
[skip ci]

## [3.43.2](v3.43.1...v3.43.2) (2023-09-01)

### Bug Fixes

* author info ([#581](#581)) ([6dd241d](6dd241d))
@elrrrrrrr elrrrrrrr mentioned this pull request Sep 1, 2023
Merged
fengmk2 pushed a commit that referenced this pull request Sep 1, 2023
@elrrrrrrr
fix: author display in cli (#582)
9b2dc41 
> Revert ineffective changes from
#581, add username index
* 🧶 Add username field to maintainers in search results, handle
uniformly when writing
* 📚 Update index documentation
-----
> 回滚 #581 无效改动，添加 username 索引
* 🧶 搜索结果中的 maintainers 添加 username 字段，写入时统一处理
* 📚 更新索引文档说明
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fengmk2 fengmk2 fengmk2 approved these changes

@Beace Beace Awaiting requested review from Beace

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elrrrrrrr @fengmk2