fix: unpkg lock #629
Merged
fix: unpkg lock #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elrrrrrrr
force-pushed
the
unpkg-lock
branch
from
d12d928 to
f4d416c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #629 +/- ##
==========================================
- Coverage 97.45% 96.85% -0.60%
==========================================
Files 168 180 +12
Lines 15691 17567 +1876
Branches 2018 2290 +272
==========================================
+ Hits 15291 17014 +1723
- Misses 400 553 +153 ☔ View full report in Codecov by Sentry. |
fengmk2
reviewed
Dec 25, 2023
| @@ -50,8 +54,16 @@ export class PackageVersionFileService extends AbstractService { | |||
| async #ensurePackageVersionFilesSync(pkgVersion: PackageVersion) { | |||
| const hasFiles = await this.packageVersionFileRepository.hasPackageVersionFiles(pkgVersion.packageVersionId); | |||
| if (!hasFiles) { | |||
| await this.syncPackageVersionFiles(pkgVersion); | |||
| const lockRes = await this.cacheAdapter.usingLock(`${pkgVersion.packageVersionId}:syncFiles`, 60, async () => { | |||
fengmk2
approved these changes
Dec 25, 2023
fengmk2
pushed a commit
that referenced
this pull request
Dec 25, 2023
[skip ci] ## [3.49.3](v3.49.2...v3.49.3) (2023-12-25) ### Bug Fixes * unpkg lock ([#629](#629)) ([5a8a4eb](5a8a4eb))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensurePackageVersionFilesSyncfunction, with a default timeout of 60 seconds.