Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distinct processing task #406

Merged
merged 1 commit into from
Feb 14, 2023
Merged

fix: distinct processing task #406

merged 1 commit into from
Feb 14, 2023

Conversation

elrrrrrrr
Copy link
Member

相同任务并发执行时,如果上游有 changesStream 事件,可能会导致版本被错误删除。


Concurrent execution of the same task with changesStream events may cause versions to be deleted incorrectly.

@elrrrrrrr elrrrrrrr added the bug Something isn't working label Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #406 (cbf730a) into master (f7344eb) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   97.61%   97.43%   -0.19%     
==========================================
  Files         152      152              
  Lines       13271    13281      +10     
  Branches     1725     1722       -3     
==========================================
- Hits        12955    12940      -15     
- Misses        316      341      +25     
Impacted Files Coverage Δ
app/core/service/TaskService.ts 97.77% <100.00%> (-1.67%) ⬇️
app/infra/NFSClientAdapter.ts 86.58% <0.00%> (-8.54%) ⬇️
config/config.default.ts 87.64% <0.00%> (-8.43%) ⬇️
app/common/adapter/CacheAdapter.ts 96.05% <0.00%> (-1.32%) ⬇️
app/port/typebox.ts 100.00% <0.00%> (ø)
app/core/service/PackageManagerService.ts 97.64% <0.00%> (+0.11%) ⬆️
app/port/controller/BinarySyncController.ts 97.05% <0.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@gemwuu gemwuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 merged commit c43c067 into master Feb 14, 2023
@fengmk2 fengmk2 deleted the feat-distinct-task branch February 14, 2023 08:18
fengmk2 pushed a commit that referenced this pull request Feb 14, 2023
[skip ci]

## [3.4.2](v3.4.1...v3.4.2) (2023-02-14)

### Bug Fixes

* distinct processing task ([#406](#406)) ([c43c067](c43c067))
@github-actions
Copy link

🎉 This PR is included in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants