Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init sync spec registry #433

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix: init sync spec registry #433

merged 1 commit into from
Apr 3, 2023

Conversation

elrrrrrrr
Copy link
Member

@elrrrrrrr elrrrrrrr commented Apr 3, 2023

Fixed the issue where the registry was not correctly matched when synchronizing scoped packages for the first time

  • Add scope params in initSpecRegistry

修复初次同步 scope 包,未正确匹配 registry 的问题

  • 修改 initSpecRegistry 方法,统一传入 scope 参数

@elrrrrrrr elrrrrrrr added the bug Something isn't working label Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #433 (6b9d302) into master (4ee410a) will decrease coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   97.26%   97.09%   -0.18%     
==========================================
  Files         156      156              
  Lines       13983    13997      +14     
  Branches     1790     1792       +2     
==========================================
- Hits        13601    13590      -11     
- Misses        382      407      +25     
Impacted Files Coverage Δ
app/core/service/PackageSyncerService.ts 98.66% <100.00%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fengmk2 fengmk2 merged commit eedfb2b into master Apr 3, 2023
@fengmk2 fengmk2 deleted the init-sync-spec-registry branch April 3, 2023 03:42
fengmk2 pushed a commit that referenced this pull request Apr 3, 2023
[skip ci]

## [3.11.2](v3.11.1...v3.11.2) (2023-04-03)

### Bug Fixes

* init sync spec registry ([#433](#433)) ([eedfb2b](eedfb2b))
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

🎉 This PR is included in version 3.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants